-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[py]: enable fedcm tests for chrome #16118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As per https://issues.chromium.org/issues/425801332 this should be resolved once Chrome 140 is out. Manual test against chrome canary verifies this. |
Nice. We might want to setup CI so we can test against beta releases of Chrome (I think Ruby bindings do this). I'm not sure if it would add too much noise... but it would be cool to see breaking changes and fixes in upcoming releases so we can be ready when they hit the stable channel. |
We already have http archives for Currently, the bazel targets look like - I made some changes, I will open a draft PR to see if it works as intended. |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
User description
🔗 Related Issues
https://issues.chromium.org/issues/425801332
💥 What does this PR do?
Enable FedCM tests for chrome
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Tests
Description
Remove Chrome xfail marker for FedCM tests
Enable FedCM testing for Chrome browser
Diagram Walkthrough
File Walkthrough
fedcm_tests.py
Remove Chrome xfail for FedCM tests
py/test/selenium/webdriver/common/fedcm_tests.py
@pytest.mark.xfail_chrome
decorator